[
https://issues.apache.org/jira/browse/DRILL-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445341#comment-16445341
]
ASF GitHub Bot commented on DRILL-6334:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1213#discussion_r182949848
--- Diff:
exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java
---
@@ -37,6 +37,7 @@ public void testSettingSameValueCount()
{
try (RootAllocator allocator = new RootAllocator(10_000_000)) {
final MaterializedField field =
MaterializedField.create("stringCol",
Types.required(TypeProtos.MinorType.VARCHAR));
+ @SuppressWarnings("resource")
--- End diff --
These warnings may be unique to Eclipse. In this case, the vector is
created, but not used in try-with-catch block which is the key purpose of
anything that derives from `AutoCloseable`. Drill uses that class simply as a
"close() without throwing exceptions" interface.
Since the warning really does not help in Drill, (and may not appear in
IntelliJ), I can just turn the warning off in Eclipse so I'm not tempted to
silence the warnings by inserting these annotations.
> Code cleanup
> ------------
>
> Key: DRILL-6334
> URL: https://issues.apache.org/jira/browse/DRILL-6334
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Trivial
> Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> Minor cleanup of a few files. Done as a separate PR to allow easier review.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
