[
https://issues.apache.org/jira/browse/DRILL-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445080#comment-16445080
]
ASF GitHub Bot commented on DRILL-6335:
---------------------------------------
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/1218#discussion_r182921553
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/RowSetLoaderImpl.java
---
@@ -95,4 +96,10 @@ public void endBatch() {
@Override
public int rowCount() { return rsLoader.rowCount(); }
+
+ @Override
+ public ColumnMetadata schema() {
+ // No column for the row tuple
+ return null;
--- End diff --
this comment is not clear to me. is it ok to return null here ?
> Refactor row set abstractions to prepare for unions
> ---------------------------------------------------
>
> Key: DRILL-6335
> URL: https://issues.apache.org/jira/browse/DRILL-6335
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.14.0
>
>
> The row set abstractions will eventually support unions and lists. The
> changes to support these types are extensive. This PR introduces refactoring
> that puts the pieces in the correct location to allow for inserting those
> additional types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
