[ 
https://issues.apache.org/jira/browse/DRILL-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445083#comment-16445083
 ] 

ASF GitHub Bot commented on DRILL-6335:
---------------------------------------

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1218#discussion_r182922226
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetWriterImpl.java 
---
    @@ -158,4 +159,10 @@ public SingleRowSet done() {
       public int lastWriteIndex() {
         return writerIndex.vectorIndex();
       }
    +
    +  @Override
    +  public ColumnMetadata schema() {
    +    // No column schema for the row as a whole.
    --- End diff --
    
    same comment as above


> Refactor row set abstractions to prepare for unions
> ---------------------------------------------------
>
>                 Key: DRILL-6335
>                 URL: https://issues.apache.org/jira/browse/DRILL-6335
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The row set abstractions will eventually support unions and lists. The 
> changes to support these types are extensive. This PR introduces refactoring 
> that puts the pieces in the correct location to allow for inserting those 
> additional types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to