[jira] [Commented] (DRILL-6347) Inconsistent method name "field".

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448099#comment-16448099
 ] 

ASF GitHub Bot commented on DRILL-6347:
---------------------------------------

Github user HanumathRao commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1236#discussion_r183384261
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java
 ---
    @@ -88,10 +88,10 @@ public void endFields() {
         }
     
         public void field(String label, boolean value) {
    -      field(label, Boolean.toString(value));
    +      append(label, Boolean.toString(value));
         }
     
    -    private void field(String label, String value) {
    +    private void append(String label, String value) {
    --- End diff --
    
    Thanks Bruce for the changes. As Arina pointed out, appendField would be 
more meaningful in this context.


> Inconsistent method name "field".
> ---------------------------------
>
>                 Key: DRILL-6347
>                 URL: https://issues.apache.org/jira/browse/DRILL-6347
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Assignee: KuiLIU
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The following method is names as "field", but the method is mainly doing 
> appending. So that, rename the method as "append" should be better.
> {code:java}
>  private void field(String label, String value) {
>       indent();
>       out.append(label)
>          .append(" = ")
>          .append(value)
>          .append("\n");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)