[
https://issues.apache.org/jira/browse/DRILL-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448863#comment-16448863
]
ASF GitHub Bot commented on DRILL-6347:
---------------------------------------
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
IMO, neither `append` or `appendField` is a good choice (otherwise it is
necessary to change `startNode/endNode` to `appendStart/EndNode`). It is either
`field` or `visitField` and should follow visitor design pattern. It may be
also good to change `listField` to the same name used for `Boolean` and
`String`.
> Inconsistent method name "field".
> ---------------------------------
>
> Key: DRILL-6347
> URL: https://issues.apache.org/jira/browse/DRILL-6347
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: KuiLIU
> Assignee: KuiLIU
> Priority: Major
> Fix For: 1.14.0
>
>
> The following method is names as "field", but the method is mainly doing
> appending. So that, rename the method as "append" should be better.
> {code:java}
> private void field(String label, String value) {
> indent();
> out.append(label)
> .append(" = ")
> .append(value)
> .append("\n");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
