[
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450086#comment-16450086
]
ASF GitHub Bot commented on DRILL-6094:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1232#discussion_r183771627
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -382,13 +407,26 @@ public RelDataType inferReturnType(SqlOperatorBinding
opBinding) {
final RelDataType operandType = opBinding.getOperandType(0);
final TypeProtos.MinorType inputMinorType =
getDrillTypeFromCalciteType(operandType);
-
if(TypeCastRules.getLeastRestrictiveType(Lists.newArrayList(inputMinorType,
TypeProtos.MinorType.BIGINT))
+ if
(TypeCastRules.getLeastRestrictiveType(Lists.newArrayList(inputMinorType,
TypeProtos.MinorType.BIGINT))
== TypeProtos.MinorType.BIGINT) {
return createCalciteTypeWithNullability(
factory,
SqlTypeName.BIGINT,
isNullable);
- } else
if(TypeCastRules.getLeastRestrictiveType(Lists.newArrayList(inputMinorType,
TypeProtos.MinorType.FLOAT8))
+ } else if
(TypeCastRules.getLeastRestrictiveType(Lists.newArrayList(inputMinorType,
TypeProtos.MinorType.FLOAT4))
--- End diff --
Please add explanation.
> Decimal data type enhancements
> ------------------------------
>
> Key: DRILL-6094
> URL: https://issues.apache.org/jira/browse/DRILL-6094
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> Currently, Decimal types are disabled by default since existing Decimal
> implementation has a lot of flaws and performance problems. The goal of this
> Jira to describe majority of them and possible ways of improving existing
> implementation to be able to enable Decimal data types by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
