[
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450088#comment-16450088
]
ASF GitHub Bot commented on DRILL-6094:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1232#discussion_r183356082
--- Diff: exec/vector/src/main/codegen/templates/ValueHolders.java ---
@@ -32,99 +32,81 @@
/*
* This class is generated using freemarker and the ${.template_name}
template.
*/
-public final class ${className} implements ValueHolder{
+public final class ${className} implements ValueHolder {
public static final MajorType TYPE =
Types.${mode.name?lower_case}(MinorType.${minor.class?upper_case});
- <#if mode.name == "Repeated">
+ <#if mode.name == "Repeated">
- /** The first index (inclusive) into the Vector. **/
- public int start;
+ /** The first index (inclusive) into the Vector. **/
+ public int start;
- /** The last index (exclusive) into the Vector. **/
- public int end;
+ /** The last index (exclusive) into the Vector. **/
+ public int end;
- /** The Vector holding the actual values. **/
- public ${minor.class}Vector vector;
+ /** The Vector holding the actual values. **/
+ public ${minor.class}Vector vector;
- <#else>
- public static final int WIDTH = ${type.width};
+ <#else>
+ public static final int WIDTH = ${type.width};
- <#if mode.name == "Optional">public int isSet;</#if>
- <#assign fields = minor.fields!type.fields />
- <#list fields as field>
- public ${field.type} ${field.name};
- </#list>
+ <#if mode.name == "Optional">public int isSet;</#if>
+ <#assign fields = minor.fields!type.fields />
+ <#list fields as field>
+ public ${field.type} ${field.name};
+ </#list>
- <#if minor.class.startsWith("Decimal")>
- public static final int maxPrecision = ${minor.maxPrecisionDigits};
- <#if minor.class.startsWith("Decimal28") ||
minor.class.startsWith("Decimal38")>
- public static final int nDecimalDigits = ${minor.nDecimalDigits};
+ <#if minor.class.startsWith("Decimal")>
+ public static final int maxPrecision = ${minor.maxPrecisionDigits};
+ <#if minor.class.startsWith("Decimal28") ||
minor.class.startsWith("Decimal38")>
--- End diff --
Please mark old decimal value holders as deprecated.
> Decimal data type enhancements
> ------------------------------
>
> Key: DRILL-6094
> URL: https://issues.apache.org/jira/browse/DRILL-6094
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> Currently, Decimal types are disabled by default since existing Decimal
> implementation has a lot of flaws and performance problems. The goal of this
> Jira to describe majority of them and possible ways of improving existing
> implementation to be able to enable Decimal data types by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
