[ 
https://issues.apache.org/jira/browse/DRILL-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458856#comment-16458856
 ] 

ASF GitHub Bot commented on DRILL-6348:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1237#discussion_r185064842
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
 ---
    @@ -182,13 +189,15 @@ public IterOutcome next() {
             return IterOutcome.OUT_OF_MEMORY;
           }
     
    +      // Transfer the ownership of this raw-batch to this operator for 
proper memory statistics reporting
    +      batch = batch.transferBodyOwnership(oContext.getAllocator());
    --- End diff --
    
    This should probably be done inside the [ RecordBatchLoader.load() 
](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchLoader.java#L78)
 method.
    Note that `MergingRecordBatch` has similar code and so probably suffers 
from the same memory accounting issue. All other uses of 
`RecordBatchLoader.load()` appear to be in the client code or test code so we 
are unlikely to break anything by making the change in `RecordBatchLoader`.



> Unordered Receiver does not report its memory usage
> ---------------------------------------------------
>
>                 Key: DRILL-6348
>                 URL: https://issues.apache.org/jira/browse/DRILL-6348
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Execution - Flow
>            Reporter: salim achouche
>            Assignee: salim achouche
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The Drill Profile functionality doesn't show any memory usage for the 
> Unordered Receiver operator. This is problematic when analyzing OOM 
> conditions since we cannot account for all of a query memory usage. This Jira 
> is to fix memory reporting for the Unordered Receiver operator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to