[
https://issues.apache.org/jira/browse/DRILL-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466725#comment-16466725
]
ASF GitHub Bot commented on DRILL-6348:
---------------------------------------
vrozov commented on a change in pull request #1237: DRILL-6348: Fixed code so
that Unordered Receiver reports its memory …
URL: https://github.com/apache/drill/pull/1237#discussion_r186595478
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/MergingReceiverCreator.java
##########
@@ -44,6 +44,11 @@ public MergingRecordBatch getBatch(ExecutorFragmentContext
context,
assert bufHolder != null : "IncomingBuffers must be defined for any place
a receiver is declared.";
RawBatchBuffer[] buffers =
bufHolder.getBuffers(receiver.getOppositeMajorFragmentId());
- return new MergingRecordBatch(context, receiver, buffers);
+ MergingRecordBatch mergeReceiver = new MergingRecordBatch(context,
receiver, buffers);
+
+ // Register this operator's buffer allocator so that incoming buffers are
owned by this allocator
+ bufHolder.setOprAllocator(receiver.getOppositeMajorFragmentId(),
mergeReceiver.getOprAllocator());
Review comment:
Consider moving registration of the buffer allocator inside
`MerginRecordBatch` constructor (change constructor to accept
`ExchangeFragmentContext` and `MergingReceiverPOP` only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unordered Receiver does not report its memory usage
> ---------------------------------------------------
>
> Key: DRILL-6348
> URL: https://issues.apache.org/jira/browse/DRILL-6348
> Project: Apache Drill
> Issue Type: Task
> Components: Execution - Flow
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Fix For: 1.14.0
>
>
> The Drill Profile functionality doesn't show any memory usage for the
> Unordered Receiver operator. This is problematic when analyzing OOM
> conditions since we cannot account for all of a query memory usage. This Jira
> is to fix memory reporting for the Unordered Receiver operator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
