[ 
https://issues.apache.org/jira/browse/DRILL-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461040#comment-16461040
 ] 

ASF GitHub Bot commented on DRILL-6272:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1225#discussion_r185497944
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java
 ---
    @@ -125,7 +125,7 @@ public void testHasPathThrowsDrillRuntimeException() {
     
         Mockito
             .when(client.getCache().getCurrentData(absPath))
    -        .thenThrow(Exception.class);
    +        .thenThrow(RuntimeException.class);
    --- End diff --
    
    IMO, this method needs to be changed to test 
`ZookeeperClient.hasPath(String path, boolean consistent)`. It is OK to do it 
in this PR or in a separate commit/JIRA/PR. If you decide to do it in a 
separate commit, please file JIRA.


> Remove binary jars files from source distribution
> -------------------------------------------------
>
>                 Key: DRILL-6272
>                 URL: https://issues.apache.org/jira/browse/DRILL-6272
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Vlad Rozov
>            Assignee: Arina Ielchiieva
>            Priority: Critical
>             Fix For: 1.14.0
>
>
> Per [~vrozov] the source distribution contains binary jar files under 
> exec/java-exec/src/test/resources/jars



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to