[
https://issues.apache.org/jira/browse/DRILL-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461303#comment-16461303
]
ASF GitHub Bot commented on DRILL-6272:
---------------------------------------
vrozov commented on a change in pull request #1225: DRILL-6272: Refactor
dynamic UDFs and function initializer tests to g…
URL: https://github.com/apache/drill/pull/1225#discussion_r185566720
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTTAS.java
##########
@@ -35,41 +39,46 @@
import org.apache.hadoop.fs.RemoteIterator;
import org.apache.hadoop.fs.permission.FsPermission;
import org.junit.BeforeClass;
+import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
+import org.junit.rules.ExpectedException;
import java.io.File;
import java.io.IOException;
+import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.List;
+import java.util.Optional;
import java.util.Properties;
-import java.util.UUID;
import static
org.apache.drill.exec.util.StoragePluginTestUtils.DFS_PLUGIN_NAME;
import static org.apache.drill.exec.util.StoragePluginTestUtils.DFS_TMP_SCHEMA;
import static org.hamcrest.CoreMatchers.containsString;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
@Category(SqlTest.class)
public class TestCTTAS extends BaseTestQuery {
- private static final UUID session_id =
UUID.nameUUIDFromBytes("sessionId".getBytes());
private static final String temp2_wk = "tmp2";
private static final String temp2_schema = String.format("%s.%s",
DFS_PLUGIN_NAME, temp2_wk);
+ private static String sessionId;
private static FileSystem fs;
private static FsPermission expectedFolderPermission;
private static FsPermission expectedFilePermission;
+ @Rule
+ public ExpectedException thrown = ExpectedException.none();
+
@BeforeClass
public static void init() throws Exception {
- MockUp<UUID> uuidMockUp = mockRandomUUID(session_id);
Review comment:
`UUID.randomUUID()` was mocked both for session id and temporary table name.
Can you get temporary table name the same way you do it for session id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove binary jars files from source distribution
> -------------------------------------------------
>
> Key: DRILL-6272
> URL: https://issues.apache.org/jira/browse/DRILL-6272
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vlad Rozov
> Assignee: Arina Ielchiieva
> Priority: Critical
> Fix For: 1.14.0
>
>
> Per [~vrozov] the source distribution contains binary jar files under
> exec/java-exec/src/test/resources/jars
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
