[
https://issues.apache.org/jira/browse/DRILL-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499743#comment-16499743
]
ASF GitHub Bot commented on DRILL-6459:
---------------------------------------
kkhatua commented on a change in pull request #1301: DRILL-6459: Unable to view
profile of a running query
URL: https://github.com/apache/drill/pull/1301#discussion_r192627632
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/proto/helper/QueryIdHelper.java
##########
@@ -33,7 +33,7 @@ public static String getQueryId(final QueryId queryId) {
public static QueryId getQueryIdFromString(final String queryId) {
final UUID uuid = UUID.fromString(queryId);
- return
QueryId.newBuilder().setPart1(uuid.getMostSignificantBits()).setPart2(uuid.getLeastSignificantBits()).build();
+ return
QueryId.newBuilder().setPart1(uuid.getMostSignificantBits()).setPart2(uuid.getLeastSignificantBits()).setText(queryId).build();
Review comment:
@vrozov You're right about the Query ID being identifiable by part1 and
part2. However, The PR for DRILL-5305 introduced a change to the protobuf that
embeds the Query ID as a text string too. This was so that the profile JSONs
could carry that text and a user can rename the file accordingly when
attempting to render the profile in the WebUI.
That change causes a situation where the instance of a QueryID created by
the foreman of a submitted query carries the text string. But when some other
thread might need to instantiate a query ID object based on the query ID's
string representation, this value is not set. So, the comparison between a
foreman's QueryID instance and a query ID generated by a WebServer thread will
not match. This fixes that. In this case, this lookup for a query ID fails
despite the entry being there.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java#L326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unable to view profile of a running query
> -----------------------------------------
>
> Key: DRILL-6459
> URL: https://issues.apache.org/jira/browse/DRILL-6459
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.14.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Critical
> Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> When running a query on the current master (), the query lists in the
> _Running Queries_ table. But when trying to view the profile, the following
> error appears:
> {code:java}
> {
> "errorMessage" : "VALIDATION ERROR: No profile with given query id
> '24ee72cd-893d-e359-4811-ad79905410a1' exists. Please verify the query
> id.\n\n\n[Error Id: 59ef7486-889e-4bc9-a96a-b47c3421cfaf ]"
> }
> {code}
> I suspect this might have to do with version-related changes to the profile's
> LocalPersistentStore or changes to the registering of running queries.
>
> The query, however, is eventually available on completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
