[
https://issues.apache.org/jira/browse/DRILL-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502817#comment-16502817
]
ASF GitHub Bot commented on DRILL-6459:
---------------------------------------
sohami commented on a change in pull request #1301: DRILL-6459: Unable to view
profile of a running query
URL: https://github.com/apache/drill/pull/1301#discussion_r193287965
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/proto/helper/QueryIdHelper.java
##########
@@ -33,7 +33,7 @@ public static String getQueryId(final QueryId queryId) {
public static QueryId getQueryIdFromString(final String queryId) {
final UUID uuid = UUID.fromString(queryId);
- return
QueryId.newBuilder().setPart1(uuid.getMostSignificantBits()).setPart2(uuid.getLeastSignificantBits()).build();
+ return
QueryId.newBuilder().setPart1(uuid.getMostSignificantBits()).setPart2(uuid.getLeastSignificantBits()).setText(queryId).build();
Review comment:
I think other advantage of having text version of queryId within that class
is that it will be computed only once during creation and later just used
everywhere as compared to creating new string every time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unable to view profile of a running query
> -----------------------------------------
>
> Key: DRILL-6459
> URL: https://issues.apache.org/jira/browse/DRILL-6459
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.14.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Critical
> Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> When running a query on the current master (), the query lists in the
> _Running Queries_ table. But when trying to view the profile, the following
> error appears:
> {code:java}
> {
> "errorMessage" : "VALIDATION ERROR: No profile with given query id
> '24ee72cd-893d-e359-4811-ad79905410a1' exists. Please verify the query
> id.\n\n\n[Error Id: 59ef7486-889e-4bc9-a96a-b47c3421cfaf ]"
> }
> {code}
> I suspect this might have to do with version-related changes to the profile's
> LocalPersistentStore or changes to the registering of running queries.
>
> The query, however, is eventually available on completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
