[
https://issues.apache.org/jira/browse/DRILL-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505688#comment-16505688
]
ASF GitHub Bot commented on DRILL-6478:
---------------------------------------
sohami commented on a change in pull request #1310: DRILL-6478: enhance debug
logs for batch sizing
URL: https://github.com/apache/drill/pull/1310#discussion_r193948794
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
##########
@@ -132,8 +132,12 @@ protected MergeJoinBatch(MergeJoinPOP popConfig,
FragmentContext context, Record
super(popConfig, context, true, left, right);
// Instantiate the batch memory manager
- final int outputBatchSize = (int)
context.getOptions().getOption(ExecConstants.OUTPUT_BATCH_SIZE_VALIDATOR);
- batchMemoryManager = new MergeJoinMemoryManager(outputBatchSize, left,
right);
+ final int configuredBatchSize = (int)
context.getOptions().getOption(ExecConstants.OUTPUT_BATCH_SIZE_VALIDATOR);
+ batchMemoryManager = new MergeJoinMemoryManager(configuredBatchSize, left,
right);
+
+ if (logger.isDebugEnabled()) {
Review comment:
if condition not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> enhance debug logs for batch sizing
> -----------------------------------
>
> Key: DRILL-6478
> URL: https://issues.apache.org/jira/browse/DRILL-6478
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> Fix some issues with debug logs so QA scripts work better. Also, added batch
> sizing logs for union all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
