[
https://issues.apache.org/jira/browse/DRILL-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507658#comment-16507658
]
ASF GitHub Bot commented on DRILL-6478:
---------------------------------------
sohami commented on a change in pull request #1310: DRILL-6478: enhance debug
logs for batch sizing
URL: https://github.com/apache/drill/pull/1310#discussion_r194290441
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
##########
@@ -409,6 +426,22 @@ public void remove() {
public void close() {
super.close();
updateBatchMemoryManagerStats();
+
+ logger.debug("BATCH_STATS, incoming aggregate left: batch count : {}, avg
bytes : {}, avg row bytes : {}, record count : {}",
Review comment:
The reason for putting it is so that for each log statement internally it
doesn't check for debug level being enabled. Having single outer check will
help here. Actually same is the case with other operators close method too.
Would be good to update those as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> enhance debug logs for batch sizing
> -----------------------------------
>
> Key: DRILL-6478
> URL: https://issues.apache.org/jira/browse/DRILL-6478
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> Fix some issues with debug logs so QA scripts work better. Also, added batch
> sizing logs for union all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
