[
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512702#comment-16512702
]
ASF GitHub Bot commented on DRILL-5796:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1298: DRILL-5796:
Filter pruning for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r195487264
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetGroupScan.java
##########
@@ -261,13 +262,17 @@ public GroupScan applyFilter(LogicalExpression
filterExpr, UdfUtilities udfUtili
return null;
}
}
-
- if (ParquetRGFilterEvaluator.canDrop(filterPredicate,
columnStatisticsMap, rowGroup.getRowCount())) {
+ rowGroup.setRowsMatch(ParquetRGFilterEvaluator.matches(filterPredicate,
columnStatisticsMap, rowGroup.getRowCount()));
+ if (rowGroup.getRowsMatch() == ROWS_MATCH.NONE) {// No row comply to the
filter => drop the row group
continue;
}
+ // DRILL_6259 : in case of array, we can't know if the real value of a
repeated column exists until it is really filtered, hence we can't prune the
filter
+ if (rowGroup.getRowsMatch() == ROWS_MATCH.ALL &&
statCollector.isRepeated(schemaPathsInExpr)) {
Review comment:
`statCollector.isRepeated(schemaPathsInExpr))` -> I am not sure this is
right place to do the check. Previously all was done during predicate
evaluation, I think moving this here is quite correct. Please re-consider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
> Key: DRILL-5796
> URL: https://issues.apache.org/jira/browse/DRILL-5796
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Jean-Blas IMBERT
> Priority: Major
> Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means
> you can remove a partition only if the whole file is for the same partition.
> With parquet, you can prune the filter if the rowgroup make a partition of
> your dataset as the unit of work if the rowgroup not the file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
