[ 
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512735#comment-16512735
 ] 

ASF GitHub Bot commented on DRILL-5796:
---------------------------------------

vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning 
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r195495844
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetBooleanPredicate.java
 ##########
 @@ -27,8 +27,7 @@
 /**
  * Boolean predicates for parquet filter pushdown.
  */
-public abstract class ParquetBooleanPredicate<C extends Comparable<C>> extends 
BooleanOperator
-    implements ParquetFilterPredicate<C> {
+public abstract class ParquetBooleanPredicate<C extends Comparable<C>> extends 
BooleanOperator implements ParquetFilterPredicate<C> {
 
 Review comment:
   avoid format only changes unless something is wrong with the way how the 
code is formatted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
>                 Key: DRILL-5796
>                 URL: https://issues.apache.org/jira/browse/DRILL-5796
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Parquet
>            Reporter: Damien Profeta
>            Assignee: Jean-Blas IMBERT
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means 
> you can remove a partition only if the whole file is for the same partition. 
> With parquet, you can prune the filter if the rowgroup make a partition of 
> your dataset as the unit of work if the rowgroup not the file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to