[
https://issues.apache.org/jira/browse/DRILL-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526970#comment-16526970
]
ASF GitHub Bot commented on DRILL-4580:
---------------------------------------
Agirish commented on a change in pull request #1350: DRILL-4580: Support for
exporting storage plugin configurations
URL: https://github.com/apache/drill/pull/1350#discussion_r199026541
##########
File path: exec/java-exec/src/main/resources/rest/storage/list.ftl
##########
@@ -38,6 +38,7 @@
<td style="border:none;">
<a class="btn btn-primary"
href="/storage/${plugin.getName()}">Update</a>
<a class="btn btn-default"
onclick="doEnable('${plugin.getName()}', false)">Disable</a>
+ <a class="btn btn-default"
href="/storage/${plugin.getName()}/export"">Export</a>
Review comment:
I've added it for all plugins. For Enabled it is visible in the Storage
Plugin List Page. For Enabled + Disabled, it's also visible in the Update page.
We can make it visible for Disabled plugins in the main page - but kept it
this way to reduce UI clutter. We can also remove the Export button for enabled
plugins in the main page. Can you look at the screenshots and see what's
preferable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide options to import and export storage plugin configurations
> ------------------------------------------------------------------
>
> Key: DRILL-4580
> URL: https://issues.apache.org/jira/browse/DRILL-4580
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP
> Reporter: Abhishek Girish
> Assignee: Abhishek Girish
> Priority: Major
> Fix For: 1.14.0
>
>
> In a few scenarios, such as upgrading Drill or duplicating an existing Drill
> setup, options from the Drill Web UI to import and export storage plugin
> configurations will be helpful.
> Can support exporting only one storage plugin configuration at a time (into a
> JSON file) or exporting all storage plugin configurations (a compressed dir
> with a JSON file for each plugin). Similarly for importing configurations,
> but with additional options to either overwrite an existing storage plugin
> with the same name or to add a new plugin with an different name).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
