[ 
https://issues.apache.org/jira/browse/DRILL-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527030#comment-16527030
 ] 

ASF GitHub Bot commented on DRILL-4580:
---------------------------------------

Agirish commented on a change in pull request #1350: DRILL-4580: Support for 
exporting storage plugin configurations
URL: https://github.com/apache/drill/pull/1350#discussion_r199034500
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
 ##########
 @@ -48,6 +48,7 @@
       <#else>
         <a id="enabled" class="btn btn-primary">Enable</a>
       </#if>
+      <a class="btn btn-default" 
href="/storage/${model.getName()}/export"">Export</a>
 
 Review comment:
   Thanks Chunhui! I am not sure what's needed to qualify these APIs as stable. 
Can you please clarify? I don't foresee anything which could break them in 
future releases, as it's pretty generic. 
   
   Also, I couldn't find any sample unit tests for these REST APIs - so I'm not 
sure how to proceed with it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Provide options to import and export storage plugin configurations
> ------------------------------------------------------------------
>
>                 Key: DRILL-4580
>                 URL: https://issues.apache.org/jira/browse/DRILL-4580
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Client - HTTP
>            Reporter: Abhishek Girish
>            Assignee: Abhishek Girish
>            Priority: Major
>             Fix For: 1.14.0
>
>
> In a few scenarios, such as upgrading Drill or duplicating an existing Drill 
> setup, options from the Drill Web UI to import and export storage plugin 
> configurations will be helpful. 
> Can support exporting only one storage plugin configuration at a time (into a 
> JSON file) or exporting all storage plugin configurations (a compressed dir 
> with  a JSON file for each plugin). Similarly for importing configurations, 
> but with additional options to either overwrite an existing storage plugin 
> with the same name or to add a new plugin with an different name).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to