[
https://issues.apache.org/jira/browse/DRILL-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530769#comment-16530769
]
ASF GitHub Bot commented on DRILL-6578:
---------------------------------------
sachouche commented on a change in pull request #1360: DRILL-6578: Handle query
cancellation in Parquet reader
URL: https://github.com/apache/drill/pull/1360#discussion_r199673902
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -109,6 +109,8 @@
/** {@inheritDoc} */
@Override
public boolean hasNext() {
+ checkCancellation(); // Checks whether query cancellation has been called
Review comment:
do you mean rename the method to checkInterrupted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure the Flat Parquet Reader can handle query cancellation
> ------------------------------------------------------------
>
> Key: DRILL-6578
> URL: https://issues.apache.org/jira/browse/DRILL-6578
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
>
> * The optimized Parquet reader uses an iterator style to load column data
> * We need to ensure the code can properly handle query cancellation even in
> the presence of bugs within the hasNext() .. next() calls
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
