[
https://issues.apache.org/jira/browse/DRILL-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531693#comment-16531693
]
ASF GitHub Bot commented on DRILL-6578:
---------------------------------------
sachouche edited a comment on issue #1360: DRILL-6578: Handle query
cancellation in Parquet reader
URL: https://github.com/apache/drill/pull/1360#issuecomment-402226927
@vrozov, please confirm if this is what you are suggesting:
boolean hasNext() {
try {
checkInterrupted();
} catch (InterruptedException) {
throw new DrillRuntimeException(...);
}
same for next()
NOTE -
o If I throw InterruptedException within the loop, then this would mean I'll
have to change the setSafe() APIs to also throw InterruptedException
o This will be a bigger change as all consumer methods (of setSafe()) will
also need to handle this exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure the Flat Parquet Reader can handle query cancellation
> ------------------------------------------------------------
>
> Key: DRILL-6578
> URL: https://issues.apache.org/jira/browse/DRILL-6578
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> * The optimized Parquet reader uses an iterator style to load column data
> * We need to ensure the code can properly handle query cancellation even in
> the presence of bugs within the hasNext() .. next() calls
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
