[
https://issues.apache.org/jira/browse/DRILL-6581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535534#comment-16535534
]
ASF GitHub Bot commented on DRILL-6581:
---------------------------------------
superbstreak commented on a change in pull request #1366: [DRILL-6581] C++
Client SSL Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r200798541
##########
File path: contrib/native/client/src/clientlib/channel.hpp
##########
@@ -60,11 +66,24 @@ class UserProperties;
class ChannelContext{
public:
- ChannelContext(DrillUserProperties* props):m_properties(props){};
+ ChannelContext(DrillUserProperties*
props):m_properties(props),m_hasCertHostnameVerificationErr(false){};
virtual ~ChannelContext(){};
const DrillUserProperties* getUserProperties() const { return
m_properties;}
+
+ /// @brief Check the certiticate hostname verification status.
+ ///
+ /// @return if the verification has failed.
+ const bool HasCertHostnameVerificationError() const {return
m_hasCertHostnameVerificationErr;}
Review comment:
I think we should put these inside SSLChannelContext since these are SSL
related items
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve C++ Client SSL Implementation
> -------------------------------------
>
> Key: DRILL-6581
> URL: https://issues.apache.org/jira/browse/DRILL-6581
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - C++
> Affects Versions: 1.12.0
> Reporter: Rob Wu
> Assignee: Rob Wu
> Priority: Major
>
> # Fix: Hostname verification doesnt function as expected: Host and port in
> the ssl hostname verification callback is always empty.
> # Fix: Certificate load verification exceptions are swallowed and not
> propagated.
> # Improvement: SSL V3 is not disabled.
> # Improvement: Hostname verification failure exception is the same as other
> certificate verification failures, we should separate them
> # Improvement: Create individual error messages to allow error handling of
> the application using the client and follows the standard of the rest of the
> errors
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
