[
https://issues.apache.org/jira/browse/DRILL-6581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539365#comment-16539365
]
ASF GitHub Bot commented on DRILL-6581:
---------------------------------------
superbstreak commented on a change in pull request #1366: [DRILL-6581] C++
Client SSL Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r201527041
##########
File path: contrib/native/client/src/clientlib/channel.cpp
##########
@@ -211,6 +211,21 @@ ChannelContext*
ChannelFactory::getChannelContext(channelType_t t, DrillUserProp
}
pChannelContext = new SSLChannelContext(props, tlsVersion,
verifyMode);
+
+ if (props->isPropSet(USERPROP_CUSTOM_SSLCTXOPTIONS)){
Review comment:
This is an optional settings that the client application can set since the
default configuration from boost is somewhat limited. And also based on the
version of boost the client is compiled against, some configurations are not
available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve C++ Client SSL Implementation
> -------------------------------------
>
> Key: DRILL-6581
> URL: https://issues.apache.org/jira/browse/DRILL-6581
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - C++
> Affects Versions: 1.12.0
> Reporter: Rob Wu
> Assignee: Rob Wu
> Priority: Major
> Fix For: 1.14.0
>
>
> # Fix: Hostname verification doesnt function as expected: Host and port in
> the ssl hostname verification callback is always empty.
> # Fix: Certificate load verification exceptions are swallowed and not
> propagated.
> # Improvement: SSL V3 is not disabled.
> # Improvement: Hostname verification failure exception is the same as other
> certificate verification failures, we should separate them
> # Improvement: Create individual error messages to allow error handling of
> the application using the client and follows the standard of the rest of the
> errors
> # Improvement: Add SSL Hostname verification with zookeeper connection mode
> support
> # Added support for custom SSL CTX Options
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
