[
https://issues.apache.org/jira/browse/DRILL-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580580#comment-16580580
]
ASF GitHub Bot commented on DRILL-6644:
---------------------------------------
Ben-Zvi commented on a change in pull request #1409: DRILL-6644: Don't reserve
space for incoming probe batches unnecessarily during the build phase.
URL: https://github.com/apache/drill/pull/1409#discussion_r210144994
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
##########
@@ -379,7 +379,7 @@ public void testLeftHashJoinLeftEmpty() throws Exception {
.build();
RecordBatch joinBatch = new PopBuilder()
- .physicalOperator(new HashJoinPOP(null, null,
Lists.newArrayList(joinCond("a", "EQUALS", "a2")), JoinRelType.LEFT))
+ .physicalOperator(new HashJoinPOP(null, null,
Lists.newArrayList(joinCond("a2", "EQUALS", "a")), JoinRelType.LEFT))
Review comment:
Good catch .... so it took the calculator to fail to note that the columns
were mismatched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> In Some Cases The HashJoin Memory Calculator Over Reserves Memory For The
> Probe Side During The Build Phase
> -----------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6644
> URL: https://issues.apache.org/jira/browse/DRILL-6644
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
> There are two cases where the HashJoin Memory calculator over reserves memory:
> 1. It reserves a maximum incoming probe batch size during the build phase.
> This is not really necessary because we will not fetch probe data until the
> probe phase. We only have to account for the data received during
> OK_NEW_SCHEMA.
> 2. https://issues.apache.org/jira/browse/DRILL-6646
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
