[ 
https://issues.apache.org/jira/browse/DRILL-6644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581583#comment-16581583
 ] 

ASF GitHub Bot commented on DRILL-6644:
---------------------------------------

ilooner commented on issue #1409: DRILL-6644: Don't reserve space for incoming 
probe batches unnecessarily during the build phase.
URL: https://github.com/apache/drill/pull/1409#issuecomment-413329411
 
 
   @Ben-Zvi thanks for the review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> In Some Cases The HashJoin Memory Calculator Over Reserves Memory For The 
> Probe Side During The Build Phase
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6644
>                 URL: https://issues.apache.org/jira/browse/DRILL-6644
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.14.0
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.15.0
>
>
> There are two cases where the HashJoin Memory calculator over reserves memory:
>  1. It reserves a maximum incoming probe batch size during the build phase. 
> This is not really necessary because we will not fetch probe data until the 
> probe phase. We only have to account for the data received during 
> OK_NEW_SCHEMA.
>  2. https://issues.apache.org/jira/browse/DRILL-6646



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to