[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583540#comment-16583540
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r210826565
##########
File path:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Bug1735ResultSetCloseReleasesBuffersTest.java
##########
@@ -69,23 +69,19 @@ public static void tearDownClass() {
public void test() throws Exception {
withNoDefaultSchema()
.withConnection(
- new Function<Connection, Void>() {
- public Void apply( Connection connection ) {
- try {
- Statement statement = connection.createStatement();
- ResultSet resultSet = statement.executeQuery( "USE dfs.tmp" );
- // TODO: Purge nextUntilEnd(...) and calls when remaining
fragment
- // race conditions are fixed (not just DRILL-2245 fixes).
- // resultSet.close( resultSet );
- statement.close();
- // connection.close() is in withConnection(...)
- return null;
- } catch ( SQLException e ) {
- throw new RuntimeException( e );
- }
+ (Function<Connection, Void>) connection -> {
Review comment:
Possibly rename class name, Test should in the beginning of the name
Test annotation, proper test name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
