[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583510#comment-16583510
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r207704625
##########
File path:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStore.java
##########
@@ -138,9 +137,11 @@ public synchronized void delete(String key) {
@Override
public Iterator<Entry<String, V>> getRange(int skip, int take) {
- final Iterator<Entry<String, V>> iter = new Iter(take);
- Iterators.advance(iter, skip);
- return Iterators.limit(iter, take);
+ Iterable<Entry<String, V>> entries = () -> new Iter(take);
Review comment:
There is no need to create new objects: neither Stream objects, nor Iterator
wrappers.
Please update `Iter` inner class to allow specifying ranges (skip (aka
offset) and limit).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
