[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583508#comment-16583508
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r206261239
##########
File path:
common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java
##########
@@ -129,22 +127,17 @@ public void clear() {
@Override
public Collection<V> values() {
- return Lists.newArrayList(Iterables.transform(secondary.entries(), new
Function<IntObjectMap.Entry<V>, V>() {
- @Override
- public V apply(IntObjectMap.Entry<V> entry) {
- return Preconditions.checkNotNull(entry).value();
- }
- }));
+ return StreamSupport.stream(secondary.entries().spliterator(), false)
+ .map(entry -> Objects.requireNonNull(entry).value())
+ .collect(Collectors.toList());
}
@Override
public Set<Entry<K, V>> entrySet() {
- return Sets.newHashSet(Iterables.transform(primary.entrySet(), new
Function<Entry<K, Entry<Integer, V>>, Entry<K, V>>() {
- @Override
- public Entry<K, V> apply(Entry<K, Entry<Integer, V>> entry) {
- return new AbstractMap.SimpleImmutableEntry<>(entry.getKey(),
entry.getValue().getValue());
- }
- }));
+ return primary.entrySet().stream()
+ .map((Function<Entry<K, Entry<Integer, V>>, Entry<K, V>>) entry ->
Review comment:
Could you remove the type of lambda expession?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
