[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583514#comment-16583514
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r207750457
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
##########
@@ -81,20 +81,20 @@ public String getTypeName() {
}
@Override
- public List<Pair<String, ? extends Table>> getTablesByNamesByBulkLoad(final
List<String> tableNames,
- final int bulkSize) {
- final String schemaName = getName();
- final List<org.apache.hadoop.hive.metastore.api.Table> tables =
DrillHiveMetaStoreClient
+ public List<Pair<String, ? extends Table>>
getTablesByNamesByBulkLoad(List<String> tableNames,
+ int bulkSize) {
+ String schemaName = getName();
+ List<org.apache.hadoop.hive.metastore.api.Table> tables =
DrillHiveMetaStoreClient
.getTablesByNamesByBulkLoadHelper(mClient, tableNames, schemaName,
bulkSize);
- final List<Pair<String, ? extends Table>> tableNameToTable =
Lists.newArrayList();
+ List<Pair<String, ? extends Table>> tableNameToTable = new ArrayList<>();
for (final org.apache.hadoop.hive.metastore.api.Table table : tables) {
Review comment:
final in forEach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
