[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583534#comment-16583534
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r210824891
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/spnego/TestSpnegoConfig.java
##########
@@ -123,7 +123,7 @@ public void testSpnegoConfigOnlyKeytab() throws Exception {
@Test
public void testSpnegoConfigOnlyPrincipal() throws Exception {
try {
- final DrillConfig newConfig = new
DrillConfig(DrillConfig.create().withValue(ExecConstants.USER_AUTHENTICATION_ENABLED,
ConfigValueFactory.fromAnyRef(true)).withValue(ExecConstants.AUTHENTICATION_MECHANISMS,
ConfigValueFactory.fromIterable(Lists.newArrayList("plain"))).withValue(ExecConstants.HTTP_SPNEGO_PRINCIPAL,
ConfigValueFactory.fromAnyRef(spnegoHelper.SERVER_PRINCIPAL)).withValue(ExecConstants.USER_AUTHENTICATOR_IMPL,
ConfigValueFactory.fromAnyRef(UserAuthenticatorTestImpl.TYPE)));
+ final DrillConfig newConfig = new
DrillConfig(DrillConfig.create().withValue(ExecConstants.USER_AUTHENTICATION_ENABLED,
ConfigValueFactory.fromAnyRef(true)).withValue(ExecConstants.AUTHENTICATION_MECHANISMS,
ConfigValueFactory.fromIterable(Collections.singletonList("plain"))).withValue(ExecConstants.HTTP_SPNEGO_PRINCIPAL,
ConfigValueFactory.fromAnyRef(spnegoHelper.SERVER_PRINCIPAL)).withValue(ExecConstants.USER_AUTHENTICATOR_IMPL,
ConfigValueFactory.fromAnyRef(UserAuthenticatorTestImpl.TYPE)));
Review comment:
the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
