[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586345#comment-16586345
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r211361059
##########
File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java
##########
@@ -83,10 +84,10 @@
private List<Path> subDirs;
protected SubDirTestWatcher(File baseDir, boolean createAtBeginning, boolean
deleteAtEnd, List<Path> subDirs) {
- this.baseDir = Preconditions.checkNotNull(baseDir);
+ this.baseDir = Objects.requireNonNull(baseDir);
this.createAtBeginning = createAtBeginning;
this.deleteAtEnd = deleteAtEnd;
- this.subDirs = Preconditions.checkNotNull(subDirs);
+ this.subDirs = Objects.requireNonNull(subDirs);
Preconditions.checkArgument(!subDirs.isEmpty(), "The list of subDirs is
empty.");
Review comment:
@vvysotskyi arguments of both of you are really reasonable. But I prefer
don't make changes without obvious benefit. If you insist, please describe the
case and post it as [DISCUSSION] in Drill dev mailing list with a link to
current PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
