[
https://issues.apache.org/jira/browse/DRILL-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590738#comment-16590738
]
ASF GitHub Bot commented on DRILL-6633:
---------------------------------------
vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r212435377
##########
File path:
common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java
##########
@@ -54,7 +51,7 @@
public class MapWithOrdinal<K, V> implements Map<K, V> {
private final static Logger logger =
LoggerFactory.getLogger(MapWithOrdinal.class);
- private final Map<K, Entry<Integer, V>> primary = Maps.newLinkedHashMap();
+ private final Map<K, Entry<Integer, V>> primary = new LinkedHashMap<>();
private final IntObjectHashMap<V> secondary = new IntObjectHashMap<>();
private final Map<K, V> delegate = new Map<K, V>() {
Review comment:
@vvysotskyi The same question as in #1264 what is the purpose (use case) of
the class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace usage of Guava classes by JDK ones
> ------------------------------------------
>
> Key: DRILL-6633
> URL: https://issues.apache.org/jira/browse/DRILL-6633
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Currently, Drill uses classes from Guava which can be replaced after moving
> to JDK 8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
