[
https://issues.apache.org/jira/browse/DRILL-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596121#comment-16596121
]
ASF GitHub Bot commented on DRILL-6710:
---------------------------------------
vvysotskyi commented on a change in pull request #1451: DRILL-6710: Drill C++
Client does not handle scale = 0 properly for d…
URL: https://github.com/apache/drill/pull/1451#discussion_r213592266
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java
##########
@@ -430,19 +430,18 @@ public LogicalExpression visitFunctionCall(FunctionCall
call, FunctionLookupCont
}
}
- FunctionHolderExpression funcExpr =
matchedFuncHolder.getExpr(call.getName(), argsWithCast, call.getPosition());
- MajorType funcExprMajorType = funcExpr.getMajorType();
- if
(DecimalUtility.isObsoleteDecimalType(funcExprMajorType.getMinorType())) {
- MajorType majorType =
- MajorType.newBuilder()
- .setMinorType(MinorType.VARDECIMAL)
- .setMode(funcExprMajorType.getMode())
- .setScale(funcExprMajorType.getScale())
- .setPrecision(funcExprMajorType.getPrecision())
- .build();
- return addCastExpression(funcExpr, majorType, functionLookupContext,
errorCollector);
+ try {
+ FunctionHolderExpression funcExpr =
matchedFuncHolder.getExpr(call.getName(), argsWithCast, call.getPosition());
+ MajorType funcExprMajorType = funcExpr.getMajorType();
+ if
(DecimalUtility.isObsoleteDecimalType(funcExprMajorType.getMinorType())) {
+ MajorType majorType =
MajorType.newBuilder().setMinorType(MinorType.VARDECIMAL).setMode(funcExprMajorType.getMode()).setScale(funcExprMajorType.getScale()).setPrecision(funcExprMajorType.getPrecision()).build();
+ return addCastExpression(funcExpr, majorType,
functionLookupContext, errorCollector);
+ }
+ return funcExpr;
+ } catch (Exception ex) {
Review comment:
Could you please narrow `Exception` to `IllegalArgumentException` here and
add a comment that this exception may appear during constructing
`FunctionHolderExpression` when the function return type has an invalid scale
or precision.
Also, please restore initial formatting above for `MajorType majorType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Drill C++ Client does not handle scale = 0 properly for decimal
> ---------------------------------------------------------------
>
> Key: DRILL-6710
> URL: https://issues.apache.org/jira/browse/DRILL-6710
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Robert Hou
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.15.0
>
>
> Query is:
> select cast('999999999999999999' as decimal(18,0)) +
> cast('9999999999999999999999999999999999999' as decimal(38,0)) from data
> limit 1
> This is the error I get when my test program calls SQLExecDirect:
> The driver reported the following diagnostics whilst running SQLExecDirect
> HY000:1:40140:[MapR][Support] (40140) Scale can't be less than zero.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
