[
https://issues.apache.org/jira/browse/DRILL-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607017#comment-16607017
]
ASF GitHub Bot commented on DRILL-6732:
---------------------------------------
vdiravka commented on issue #1460: DRILL-6732: Queries are runnable on disable
plugins
URL: https://github.com/apache/drill/pull/1460#issuecomment-419414069
Hi @lushuifeng. Thanks for your first contribution and welcome!
Please take a look at unit tests, a lot of them are failed, you can easily
check the Travis build from this PR (keep in mind that some tests are excluded
from Travis build).
I suppose the reason of that failures is System Plugins. There are two
config types for them: `SystemTablePluginConfig` and `InfoSchemaConfig` and
they are not deserializable. It means they are always disabled, but should be
enabled after instantiating. If you change it, your check should pass for
system plugins too. Please verify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Queries are runnable on disable plugins
> ---------------------------------------
>
> Key: DRILL-6732
> URL: https://issues.apache.org/jira/browse/DRILL-6732
> Project: Apache Drill
> Issue Type: Bug
> Components: Security
> Affects Versions: 1.13.0, 1.14.0
> Reporter: shuifeng lu
> Priority: Critical
>
> Queries are not allowed to run on disable plugins: (1.10 works fine, 1.13 and
> 1.14 has the same problem. Not checked for 1.11 and 1.12)
> 1) It is not allowed
> 2) the plugin rules cannot be applied on queries, but queries are runnable
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
