[
https://issues.apache.org/jira/browse/DRILL-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609140#comment-16609140
]
ASF GitHub Bot commented on DRILL-6732:
---------------------------------------
vdiravka commented on a change in pull request #1460: DRILL-6732: Queries are
runnable on disable plugins
URL: https://github.com/apache/drill/pull/1460#discussion_r216309759
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/store/TestDisablePlugin.java
##########
@@ -0,0 +1,56 @@
+package org.apache.drill.exec.store.store;
+
+import org.apache.drill.categories.SqlTest;
+import org.apache.drill.common.exceptions.UserRemoteException;
+import org.apache.drill.exec.store.StoragePluginRegistry;
+import org.apache.drill.exec.store.dfs.FileSystemConfig;
+import org.apache.drill.test.BaseTestQuery;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.ExpectedException;
+
+import java.nio.file.Paths;
+
+import static
org.apache.drill.exec.util.StoragePluginTestUtils.DFS_PLUGIN_NAME;
+import static org.apache.drill.exec.util.StoragePluginTestUtils.DFS_TMP_SCHEMA;
+import static org.apache.drill.exec.util.StoragePluginTestUtils.TMP_SCHEMA;
+import static org.hamcrest.CoreMatchers.containsString;
+
+@Category(SqlTest.class)
+public class TestDisablePlugin extends BaseTestQuery {
Review comment:
It would be good to use newer `ClusterTest`, since `BaseTestQuery` is
deprecated.
You can get something similar to:
```
@BeforeClass
public static void setUp() throws Exception {
ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher);
startCluster(builder);
StoragePluginRegistry pluginRegistry =
client.cluster().drillbit().getContext().getStorage();
FileSystemConfig pluginConfig = (FileSystemConfig)
pluginRegistry.getPlugin(CP_PLUGIN_NAME).getConfig();
pluginConfig.setEnabled(false);
pluginRegistry.createOrUpdate(CP_PLUGIN_NAME, pluginConfig, true);
}
```
and `testBuilder().sqlQuery(query)`...
Consider it, but it is not mandatory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Queries are runnable on disable plugins
> ---------------------------------------
>
> Key: DRILL-6732
> URL: https://issues.apache.org/jira/browse/DRILL-6732
> Project: Apache Drill
> Issue Type: Bug
> Components: Security
> Affects Versions: 1.13.0, 1.14.0
> Reporter: shuifeng lu
> Priority: Critical
> Fix For: 1.15.0
>
>
> Queries are not allowed to run on disable plugins: (1.10 works fine, 1.13 and
> 1.14 has the same problem. Not checked for 1.11 and 1.12)
> 1) It is not allowed
> 2) the plugin rules cannot be applied on queries, but queries are runnable
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
