[
https://issues.apache.org/jira/browse/DRILL-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629367#comment-16629367
]
ASF GitHub Bot commented on DRILL-6731:
---------------------------------------
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs
aggregating work from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#discussion_r220710747
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterSink.java
##########
@@ -89,16 +142,27 @@ public void close() throws Exception {
@Override
public void run() {
- while (running.get()) {
- RuntimeFilterWritable toAggregate = rfQueue.poll();
- if (toAggregate != null) {
- if (aggregated != null) {
- aggregated.aggregate(toAggregate);
- currentBookId.incrementAndGet();
+ try {
+ while (running.get()) {
+ RuntimeFilterWritable toAggregate = rfQueue.take();
+ if (!running.get()) {
+ toAggregate.close();
+ return;
+ }
+ if (containOne()) {
+ try {
+ aggregatedRFLock.lock();
+ aggregated.aggregate(toAggregate);
Review comment:
`aggregated.close()` should be called to release Drillbuff reference it's
holding to since `aggregate()` will not do that. This change is part of branch
shared in above comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JPPD:Move aggregating the BF from the Foreman to the RuntimeFilter
> ------------------------------------------------------------------
>
> Key: DRILL-6731
> URL: https://issues.apache.org/jira/browse/DRILL-6731
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.15.0
> Reporter: weijie.tong
> Assignee: weijie.tong
> Priority: Major
>
> This PR is to move the BloomFilter aggregating work from the foreman to
> RuntimeFilter. Though this change, the RuntimeFilter can apply the incoming
> BF as soon as possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
