[
https://issues.apache.org/jira/browse/DRILL-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633627#comment-16633627
]
ASF GitHub Bot commented on DRILL-6731:
---------------------------------------
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs
aggregating work from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#discussion_r221491365
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterWritable.java
##########
@@ -90,27 +95,30 @@ public RuntimeFilterWritable duplicate(BufferAllocator
bufferAllocator) {
int capacity = src.readableBytes();
DrillBuf duplicateOne = bufferAllocator.buffer(capacity);
int readerIndex = src.readerIndex();
- src.readBytes(duplicateOne, 0, capacity);
+ duplicateOne.writeBytes(src);
src.readerIndex(readerIndex);
cloned[i] = duplicateOne;
i++;
}
return new RuntimeFilterWritable(runtimeFilterBDef, cloned);
}
- public boolean same(RuntimeFilterWritable other) {
- BitData.RuntimeFilterBDef runtimeFilterDef = other.getRuntimeFilterBDef();
- int otherMajorId = runtimeFilterDef.getMajorFragmentId();
- int otherMinorId = runtimeFilterDef.getMinorFragmentId();
- int otherHashJoinOpId = runtimeFilterDef.getHjOpId();
- int thisMajorId = this.runtimeFilterBDef.getMajorFragmentId();
- int thisMinorId = this.runtimeFilterBDef.getMinorFragmentId();
- int thisHashJoinOpId = this.runtimeFilterBDef.getHjOpId();
- return otherMajorId == thisMajorId && otherMinorId == thisMinorId &&
otherHashJoinOpId == thisHashJoinOpId;
+ public String toString() {
+ return identifier;
}
- public String toString() {
- return "majorFragmentId:" + runtimeFilterBDef.getMajorFragmentId() +
",minorFragmentId:" + runtimeFilterBDef.getMinorFragmentId() + ", operatorId:"
+ runtimeFilterBDef.getHjOpId();
+ @Override
+ public boolean equals(Object other) {
Review comment:
Please include null check for other like:
```
if (other == null) {
return false;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JPPD:Move aggregating the BF from the Foreman to the RuntimeFilter
> ------------------------------------------------------------------
>
> Key: DRILL-6731
> URL: https://issues.apache.org/jira/browse/DRILL-6731
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.15.0
> Reporter: weijie.tong
> Assignee: weijie.tong
> Priority: Major
>
> This PR is to move the BloomFilter aggregating work from the foreman to
> RuntimeFilter. Though this change, the RuntimeFilter can apply the incoming
> BF as soon as possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
