[ 
https://issues.apache.org/jira/browse/DRILL-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651904#comment-16651904
 ] 

ASF GitHub Bot commented on DRILL-6795:
---------------------------------------

vdiravka commented on a change in pull request #1503: DRILL-6795: Upgrade 
Janino compiler from 2.7.6 to 3.0.9
URL: https://github.com/apache/drill/pull/1503#discussion_r225515750
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1366,6 +1366,11 @@
         <artifactId>janino</artifactId>
         <version>${janino.version}</version>
       </dependency>
+      <dependency>
+        <groupId>org.codehaus.janino</groupId>
+        <artifactId>commons-compiler</artifactId>
 
 Review comment:
   Just for clarification, it was a Transitive Dependency earlier, wasn't it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade Janino compiler from 2.7.6 to 3.0.9
> -------------------------------------------
>
>                 Key: DRILL-6795
>                 URL: https://issues.apache.org/jira/browse/DRILL-6795
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.14.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Upgrade Janino compiler from 2.7.6 to 3.0.9.
> In newer Janino version some classes were renamed; some classes were 
> refactored to correspond the visitor pattern.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to