[ 
https://issues.apache.org/jira/browse/DRILL-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652017#comment-16652017
 ] 

ASF GitHub Bot commented on DRILL-6795:
---------------------------------------

vvysotskyi commented on a change in pull request #1503: DRILL-6795: Upgrade 
Janino compiler from 2.7.6 to 3.0.9
URL: https://github.com/apache/drill/pull/1503#discussion_r225586948
 
 

 ##########
 File path: exec/java-exec/pom.xml
 ##########
 @@ -349,6 +349,14 @@
       <artifactId>joda-time</artifactId>
       <version>2.9</version>
     </dependency>
+    <dependency>
 
 Review comment:
   Currently, Drill has only transitive dependencies to `janino` and 
`commons-compiler`, but their classes are used in Drill code, so specified 
direct dependencies to avoid relying on transitive ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Upgrade Janino compiler from 2.7.6 to 3.0.9
> -------------------------------------------
>
>                 Key: DRILL-6795
>                 URL: https://issues.apache.org/jira/browse/DRILL-6795
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.14.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Upgrade Janino compiler from 2.7.6 to 3.0.9.
> In newer Janino version some classes were renamed; some classes were 
> refactored to correspond the visitor pattern.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to