[
https://issues.apache.org/jira/browse/DRILL-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695069#comment-16695069
]
ASF GitHub Bot commented on DRILL-6834:
---------------------------------------
vvysotskyi commented on a change in pull request #1549: DRILL-6834: Introduce
option to disable result set on CTAS, create vi…
URL: https://github.com/apache/drill/pull/1549#discussion_r235477411
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -876,4 +876,12 @@ public static String bootDefaultFor(String name) {
public static final String LIST_FILES_RECURSIVELY =
"storage.list_files_recursively";
public static final BooleanValidator LIST_FILES_RECURSIVELY_VALIDATOR = new
BooleanValidator(LIST_FILES_RECURSIVELY,
new OptionDescription("Enables recursive files listing when querying the
`INFORMATION_SCHEMA.FILES` table or executing the SHOW FILES command. Default
is false. (Drill 1.15+"));
+
+ public static final String FETCH_RESULT_SET_FOR_DDL =
"drill.exec.fetch_resultset_for_ddl";
+ public static final BooleanValidator FETCH_RESULT_SET_FOR_DDL_VALIDATOR =
new BooleanValidator(FETCH_RESULT_SET_FOR_DDL,
+ new OptionDescription("Controls whether to fetch result set for CREATE
TABLE/VIEW, DROP TABLE/VIEW, SET, USE etc. queries"));
+
+ public static final String SQL_NODE_KIND = "drill.exec.query_sqlnode_kind";
Review comment:
Since these options are used for internal purposes, is it makes sense to
move them somewhere to the place where they are used, so we will not mix user
end options with internal ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Introduce option to disable result set on CTAS, create view and drop
> table/view etc. for JDBC connection
> --------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6834
> URL: https://issues.apache.org/jira/browse/DRILL-6834
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> There are some tools (Unica, dBeaver, TalenD) that do not expect to obtain
> result set on CTAS query. As a result the query gets canceled. Hive, on the
> other hand, does not return result set for the query and these tools work
> well.
> To improve Drill's integration with such tools a session option
> {{`drill.exec.fetch_resultset_for_ddl`}} is introduced. If the option is
> enabled (set to `true`) Drill's behaviour will be unchanged, i.e. all result
> set will be returned for all queries. If the option is disabled (set to
> `false`), CTAS, CREATE VIEW, CREATE FUNCTION, DROP TABLE, DROP VIEW, DROP
> FUNCTION, USE schema, SET option, REFRESH METADATA TABLE etc. queries will
> not return result set but {{updateCount}} instead.
> The option affects JDBC connections only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
