[
https://issues.apache.org/jira/browse/DRILL-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695073#comment-16695073
]
ASF GitHub Bot commented on DRILL-6834:
---------------------------------------
vvysotskyi commented on a change in pull request #1549: DRILL-6834: Introduce
option to disable result set on CTAS, create vi…
URL: https://github.com/apache/drill/pull/1549#discussion_r235493106
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/materialize/VectorRecordMaterializer.java
##########
@@ -25,35 +27,44 @@
import org.apache.drill.exec.record.BatchSchema;
import org.apache.drill.exec.record.RecordBatch;
import org.apache.drill.exec.record.WritableBatch;
+import org.apache.drill.exec.server.options.OptionManager;
-public class VectorRecordMaterializer implements RecordMaterializer{
+public class VectorRecordMaterializer implements RecordMaterializer {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(VectorRecordMaterializer.class);
private QueryId queryId;
private RecordBatch batch;
private BufferAllocator allocator;
+ private OptionManager options;
public VectorRecordMaterializer(FragmentContext context, OperatorContext
oContext, RecordBatch batch) {
this.queryId = context.getHandle().getQueryId();
this.batch = batch;
this.allocator = oContext.getAllocator();
BatchSchema schema = batch.getSchema();
assert schema != null : "Schema must be defined.";
-
-// for (MaterializedField f : batch.getSchema()) {
-// logger.debug("New Field: {}", f);
-// }
+ options = context.getOptions();
}
public QueryWritableBatch convertNext() {
- //batch.getWritableBatch().getDef().getRecordCount()
WritableBatch w = batch.getWritableBatch().transfer(allocator);
+ QueryData.Builder builder = QueryData.newBuilder()
+ .setQueryId(queryId)
+ .setRowCount(batch.getRecordCount())
+ .setDef(w.getDef());
+ if (hasUpdateCount()) {
+ int count = w.getDef().getUpdateCount();
+ builder.setUpdateCount(count == -1 ? 0 : count);
+ }
+ return new QueryWritableBatch(builder.build(), w.getBuffers());
+ }
- QueryData header = QueryData.newBuilder() //
- .setQueryId(queryId) //
- .setRowCount(batch.getRecordCount()) //
- .setDef(w.getDef()).build();
- QueryWritableBatch batch = new QueryWritableBatch(header, w.getBuffers());
- return batch;
+ private boolean hasUpdateCount() {
Review comment:
Could you please rename this method to something more descriptive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce option to disable result set on CTAS, create view and drop
> table/view etc. for JDBC connection
> --------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6834
> URL: https://issues.apache.org/jira/browse/DRILL-6834
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> There are some tools (Unica, dBeaver, TalenD) that do not expect to obtain
> result set on CTAS query. As a result the query gets canceled. Hive, on the
> other hand, does not return result set for the query and these tools work
> well.
> To improve Drill's integration with such tools a session option
> {{`drill.exec.fetch_resultset_for_ddl`}} is introduced. If the option is
> enabled (set to `true`) Drill's behaviour will be unchanged, i.e. all result
> set will be returned for all queries. If the option is disabled (set to
> `false`), CTAS, CREATE VIEW, CREATE FUNCTION, DROP TABLE, DROP VIEW, DROP
> FUNCTION, USE schema, SET option, REFRESH METADATA TABLE etc. queries will
> not return result set but {{updateCount}} instead.
> The option affects JDBC connections only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
