[
https://issues.apache.org/jira/browse/DRILL-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810104#comment-16810104
]
ASF GitHub Bot commented on DRILL-7063:
---------------------------------------
amansinha100 commented on pull request #1723: DRILL-7063: Seperate metadata
cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272257105
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataProviderImpl.java
##########
@@ -109,19 +109,59 @@ public Path getSelectionRoot() {
return selectionRoot;
}
+ /**
+ * Returns list of metadata cache files
+ * @param p directory path of the cache file
+ * @param fs
+ * @return list of cache files found in the given directory path
+ */
+ public List<Path> populateMetaPaths(Path p, DrillFileSystem fs) throws
IOException {
+ List<Path> metaFilepaths = new ArrayList<>();
+ for (String filename : Metadata.CURRENT_METADATA_FILENAMES) {
+ metaFilepaths.add(new Path(p, filename));
+ }
+
+ //Read the older version of metadata file if the current version of
metadata cache files donot exist.
+ for (String filename : Metadata.OLD_METADATA_FILENAMES) {
Review comment:
Should this be inside an `if` statement checking if the `metaFilePaths` is
empty (if current versions of metadata does not exist) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create separate summary file for schema, totalRowCount, totalNullCount
> (includes maintenance)
> ---------------------------------------------------------------------------------------------
>
> Key: DRILL-7063
> URL: https://issues.apache.org/jira/browse/DRILL-7063
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Venkata Jyothsna Donapati
> Assignee: Venkata Jyothsna Donapati
> Priority: Major
> Fix For: 1.16.0
>
> Original Estimate: 252h
> Remaining Estimate: 252h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
