[
https://issues.apache.org/jira/browse/DRILL-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810107#comment-16810107
]
ASF GitHub Bot commented on DRILL-7063:
---------------------------------------
amansinha100 commented on pull request #1723: DRILL-7063: Seperate metadata
cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272259357
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
##########
@@ -282,7 +286,24 @@ public static PartitionMetadata
getPartitionMetadata(SchemaPath partitionColumn,
statistics.put(ColumnStatisticsKind.NULLS_COUNT.getName(), nulls);
columnsStatistics.put(colPath, new ColumnStatisticsImpl(statistics,
comparator));
}
+ columnsStatistics = populateColumnStats(columnsStatistics, tableMetadata);
+ return columnsStatistics;
+ }
+ private static Map<SchemaPath, ColumnStatistics>
populateColumnStats(Map<SchemaPath, ColumnStatistics> columnsStatistics,
MetadataBase.ParquetTableMetadataBase parquetTableMetadata) {
Review comment:
What's the difference between this method and a similar
`populateColumnStats` in `BaseParquetMetadataProvider` ? More than 1
'populate' methods creates code maintenance issues in the future.
Minor code style: line too long ?
Also add javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Create separate summary file for schema, totalRowCount, totalNullCount
> (includes maintenance)
> ---------------------------------------------------------------------------------------------
>
> Key: DRILL-7063
> URL: https://issues.apache.org/jira/browse/DRILL-7063
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Venkata Jyothsna Donapati
> Assignee: Venkata Jyothsna Donapati
> Priority: Major
> Fix For: 1.16.0
>
> Original Estimate: 252h
> Remaining Estimate: 252h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
