[
https://issues.apache.org/jira/browse/DRILL-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863601#comment-16863601
]
ASF GitHub Bot commented on DRILL-7293:
---------------------------------------
paul-rogers commented on pull request #1807: DRILL-7293: Convert the regex
("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r293633490
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/log/TestLogReader.java
##########
@@ -389,4 +416,56 @@ public void testRawUMNoSchema() throws RpcException {
RowSetUtilities.verify(expected, results);
}
+
+ @Test
+ public void testProvidedSchema() throws Exception {
Review comment:
Short answer: it does not seem to work. I tried this in the past and found
that table functions take only simple values (numbers, strings), not lists.
Since this plugin uses a list, I never could figure out how to use it with
table functions. In particular, how would the table function know how to create
the instance of `LogFormatField` within the list? Am I missing something?
This plugin, in particular, would very much benefit from the use of a table
function so that the user does not have to define a new plugin config for each
new file type.
If there is a way to make this work, we can add the test and describe the
answer in the README file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Convert the regex ("log") plugin to use EVF
> -------------------------------------------
>
> Key: DRILL-7293
> URL: https://issues.apache.org/jira/browse/DRILL-7293
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.17.0
>
>
> The "log" plugin (which uses a regex to define the row format) is the subject
> of Chapter 12 of the Learning Apache Drill book (though the version in the
> book is simpler than the one in the master branch.)
> The recently-completed "Enhanced Vector Framework" (EVF, AKA the "row set
> framework") gives Drill control over the size of batches created by readers,
> and allows readers to use the recently-added provided schema mechanism.
> We wish to use the log reader as an example for how to convert a Drill format
> plugin to use the EVF so that other developers can convert their own plugins.
> This PR provides the first set of log plugin changes to enable us to publish
> a tutorial on the EVF.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
