[
https://issues.apache.org/jira/browse/DRILL-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866246#comment-16866246
]
ASF GitHub Bot commented on DRILL-7293:
---------------------------------------
paul-rogers commented on pull request #1807: DRILL-7293: Convert the regex
("log") plugin to use EVF
URL: https://github.com/apache/drill/pull/1807#discussion_r294614546
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/log/README.md
##########
@@ -143,6 +143,14 @@ cardinality.
You may find it helpful to specify the regex and column names via the plugin
config, types via the `CREATE SCHEMA` command.
+## Table Functions
+
+Log files come in many forms. It would be very convenient to use Drill table
Review comment:
As I recall, Drill does not have a good way to deal with changes to the
schema of a storage plugin. Some time back, I remember struggling to understand
why my server would not start, only to eventually learn that some plugin or
other changed its config and so Drill failed when trying to load the existing
config from ZK. Has this been fixed?
If we change schema to a string, we'd need to run code to convert old
configs. Also, we'd have the problem of what to do with the type property. We
could not easily convert an existing config into a table schema.
Given these uncertainties, my thought was to leave the config alone and try
to fit in the provided schema as best we can on top of the existing config.
Can you suggest a better approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Convert the regex ("log") plugin to use EVF
> -------------------------------------------
>
> Key: DRILL-7293
> URL: https://issues.apache.org/jira/browse/DRILL-7293
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.17.0
>
>
> The "log" plugin (which uses a regex to define the row format) is the subject
> of Chapter 12 of the Learning Apache Drill book (though the version in the
> book is simpler than the one in the master branch.)
> The recently-completed "Enhanced Vector Framework" (EVF, AKA the "row set
> framework") gives Drill control over the size of batches created by readers,
> and allows readers to use the recently-added provided schema mechanism.
> We wish to use the log reader as an example for how to convert a Drill format
> plugin to use the EVF so that other developers can convert their own plugins.
> This PR provides the first set of log plugin changes to enable us to publish
> a tutorial on the EVF.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
