[ 
https://issues.apache.org/jira/browse/DRILL-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875741#comment-16875741
 ] 

ASF GitHub Bot commented on DRILL-7306:
---------------------------------------

arina-ielchiieva commented on pull request #1813: DRILL-7306: Disable 
schema-only batch for new scan framework
URL: https://github.com/apache/drill/pull/1813#discussion_r298827401
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/TestSchemaWithTableFunction.java
 ##########
 @@ -17,6 +17,14 @@
  */
 package org.apache.drill;
 
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 Review comment:
   I am not sure why your IDE makes static imports on the top of the list, I 
think its more common when they are in the end. I think all Drill project 
follows this convention...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disable "fast schema" batch for new scan framework
> --------------------------------------------------
>
>                 Key: DRILL-7306
>                 URL: https://issues.apache.org/jira/browse/DRILL-7306
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.16.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.17.0
>
>
>  The EVF framework is set up to return a "fast schema" empty batch with only 
> schema as its first batch because, when the code was written, it seemed 
> that's how we wanted operators to work. However, DRILL-7305 notes that many 
> operators cannot handle empty batches.
> Since the empty-batch bugs show that Drill does not, in fact, provide a "fast 
> schema" batch, this ticket asks to disable the feature in the new scan 
> framework. The feature is disabled with a config option; it can be re-enabled 
> if ever it is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to