[
https://issues.apache.org/jira/browse/DRILL-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875884#comment-16875884
]
ASF GitHub Bot commented on DRILL-7306:
---------------------------------------
paul-rogers commented on pull request #1813: DRILL-7306: Disable schema-only
batch for new scan framework
URL: https://github.com/apache/drill/pull/1813#discussion_r298853771
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/TestSchemaWithTableFunction.java
##########
@@ -17,6 +17,14 @@
*/
package org.apache.drill;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
Review comment:
Sorry, I've manually put the imports back and have updated the Eclipse rules
to put static imports after the others.
As it turns out, the Eclipse style rules on the Drill web site are not valid
for the latest Eclipse: "Import failed. This is not a faled profile: Expected
`CleanUpProfile` but encountered `CodeFormatterProfile`. So, I've been using
the Eclipse default profile with a few adjustments per the [web
site](http://drill.apache.org/docs/apache-drill-contribution-guidelines/). The
web site does not mention a preferred import order.
I have tried disabling the auto-update of imports so that files are left
unchanged. However, this tends to leave unused imports which then cause the
build to fail and take a long time to fix manually.
Best solution: update the Eclipse settings file both to make it valid and to
include any missing style rules. Then, I'll update my IDE to enforce the
project's preferred standards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Disable "fast schema" batch for new scan framework
> --------------------------------------------------
>
> Key: DRILL-7306
> URL: https://issues.apache.org/jira/browse/DRILL-7306
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> The EVF framework is set up to return a "fast schema" empty batch with only
> schema as its first batch because, when the code was written, it seemed
> that's how we wanted operators to work. However, DRILL-7305 notes that many
> operators cannot handle empty batches.
> Since the empty-batch bugs show that Drill does not, in fact, provide a "fast
> schema" batch, this ticket asks to disable the feature in the new scan
> framework. The feature is disabled with a config option; it can be re-enabled
> if ever it is needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
