[
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909300#comment-16909300
]
ASF GitHub Bot commented on DRILL-7350:
---------------------------------------
vvysotskyi commented on pull request #1843: DRILL-7350: Move RowSet related
classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314829114
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/RowSetWriterImpl.java
##########
@@ -129,7 +129,7 @@ public RowSetWriter addRow(Object...values) {
@Override
public RowSetWriter addSingleCol(Object value) {
- return addRow(new Object[] {value});
+ return addRow(value);
Review comment:
No need to cast, it was an example. In the method where the value is used
reference type is already `Object`, so we don't need to do a cast.
> Unless we wrap that single column in another array, the second form is the
same as:
> ```
> ... addRow(new Object[] {10, "foo"});
> ```
Actually not, it will be the same as
```
addRow((Object) new Object[] {10, "foo"});
```
because method argument in `addSingleCol` has `Object` type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move RowSet related classes from test folder
> --------------------------------------------
>
> Key: DRILL-7350
> URL: https://issues.apache.org/jira/browse/DRILL-7350
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them
> for Metastore.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
