[ 
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16911166#comment-16911166
 ] 

ASF GitHub Bot commented on DRILL-7350:
---------------------------------------

vvysotskyi commented on pull request #1843: DRILL-7350: Move RowSet related 
classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r315598163
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/store/log/TestLogReader.java
 ##########
 @@ -781,9 +781,19 @@ public void testPluginSerialization() throws IOException {
 
   @Test
   public void testFirewallSchema() throws RpcException {
-    String sql = "SELECT * FROM cp.`regex/firewall.ssdlog`";
+    String sql = "SELECT * FROM cp.`regex/firewall.ssdlog` limit 0";
     RowSet result = client.queryBuilder().sql(sql).rowSet();
-    result.print();
+    TupleMetadata expectedSchema = new SchemaBuilder()
 
 Review comment:
   I have created https://issues.apache.org/jira/browse/DRILL-7354 to address 
this change.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move RowSet related classes from test folder
> --------------------------------------------
>
>                 Key: DRILL-7350
>                 URL: https://issues.apache.org/jira/browse/DRILL-7350
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them 
> for Metastore.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to