[
https://issues.apache.org/jira/browse/DRILL-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945545#comment-16945545
]
ASF GitHub Bot commented on DRILL-7385:
---------------------------------------
cgivre commented on pull request #1862: DRILL-7385: Convert PCAP Format Plugin
to EVF
URL: https://github.com/apache/drill/pull/1862#discussion_r331828669
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/schema/Schema.java
##########
@@ -78,4 +81,23 @@ public ColumnDto getColumnByIndex(int i) {
public int getNumberOfColumns() {
return columns.size();
}
+
+ public TupleMetadata buildSchema(SchemaBuilder builder) {
+ for(ColumnDto column : columns) {
+ if(column.getColumnType() == PcapTypes.BOOLEAN) {
+ builder.addNullable(column.getColumnName(), TypeProtos.MinorType.BIT);
+ } else if(column.getColumnType() == PcapTypes.INTEGER) {
+ builder.addNullable(column.getColumnName(), TypeProtos.MinorType.INT);
+ } else if(column.getColumnType() == PcapTypes.STRING) {
+ builder.addNullable(column.getColumnName(),
TypeProtos.MinorType.VARCHAR);
+ } else if(column.getColumnType() == PcapTypes.TIMESTAMP) {
+ builder.addNullable(column.getColumnName(),
TypeProtos.MinorType.TIMESTAMP);
+ } else if(column.getColumnType() == PcapTypes.LONG) {
+ builder.addNullable(column.getColumnName(),
TypeProtos.MinorType.BIGINT);
Review comment:
I feel the need for speed... Fixed and went for the fastest solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Convert PCAP Format Plugin to EVF
> ---------------------------------
>
> Key: DRILL-7385
> URL: https://issues.apache.org/jira/browse/DRILL-7385
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.17.0
>
>
> The PCAP format plugin has the possibility of extracting considerably more
> data out of PCAP files. To facilitate this, this PR updates the plugin to
> use the new Enhanced Vector Framework. No changes in functionality should
> occur.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
